Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groupby option for vectorized annotations #5956

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 25, 2023

No description provided.

This is no longer send to the frontend because of self._get_hover_data
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #5956 (1d746aa) into main (bb81fe0) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5956      +/-   ##
==========================================
- Coverage   88.58%   88.58%   -0.01%     
==========================================
  Files         315      315              
  Lines       65523    65516       -7     
==========================================
- Hits        58043    58036       -7     
  Misses       7480     7480              
Flag Coverage Δ
ui-tests 23.14% <28.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
holoviews/plotting/bokeh/__init__.py 98.14% <100.00%> (ø)
holoviews/plotting/bokeh/annotation.py 86.78% <100.00%> (+0.03%) ⬆️
...oviews/tests/plotting/bokeh/test_annotationplot.py 97.71% <100.00%> (-0.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro added this to the 1.18.1 milestone Oct 30, 2023
@hoxbro hoxbro merged commit c425668 into main Nov 2, 2023
10 checks passed
@hoxbro hoxbro deleted the fix_groupby_vlines branch November 2, 2023 10:03
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants